Skip to content

load_pem_x509_cert_str_safe: Handle str or bytes input#78

Open
zmousm wants to merge 1 commit intoIdentityPython:masterfrom
zmousm:load_pem_x509_cert_str_safe
Open

load_pem_x509_cert_str_safe: Handle str or bytes input#78
zmousm wants to merge 1 commit intoIdentityPython:masterfrom
zmousm:load_pem_x509_cert_str_safe

Conversation

@zmousm
Copy link

@zmousm zmousm commented May 22, 2024

  • Introduce utils.load_pem_x509_cert_str_safe to handle str or bytes as input to load_pem_x509_certificate
  • Use it to wrap calls to the latter where input can be str or bytes

All Submissions:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what problem you are trying to solve with this PR?
  • Have you added information on what your changes do and why you chose this as your solution?
  • Have you written new tests for your changes?
  • Does your submission pass tests?
  • This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

@zmousm
load_pem_x509_cert_str_safe: Handle str or bytes input
c6cb666 
* Introduce utils.load_pem_x509_cert_str_safe to handle str or bytes as
  input to load_pem_x509_certificate
* Use it to wrap calls to the latter where input can be str or bytes
@zmousm zmousm mentioned this pull request May 22, 2024
Closed
6 tasks
@zmousm
Copy link
Author

zmousm commented May 22, 2024

I opted to make the least changes and only wrap calls to load_pem_x509_certificate where the input may not be a bytestring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@zmousm